Skip to content

[DataFactory]Add CompressionCodec property for ORC Dataset#7452

Merged
weidongxu-microsoft merged 5 commits intoAzure:masterfrom
TinaHu1:orccompression
Oct 17, 2019
Merged

[DataFactory]Add CompressionCodec property for ORC Dataset#7452
weidongxu-microsoft merged 5 commits intoAzure:masterfrom
TinaHu1:orccompression

Conversation

@TinaHu1
Copy link
Copy Markdown
Contributor

@TinaHu1 TinaHu1 commented Oct 10, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Oct 10, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 89e4b3f, Iteration 2)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed datafactory/resource-manager/v2017_09_01_preview [Logs] [Generation PR]
  • Failed datafactory/resource-manager/v2018_06_01 [Logs]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Oct 10, 2019

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 10, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7962

This was referenced Oct 10, 2019
Merged
Closed
@AutorestCI AutorestCI mentioned this pull request Oct 10, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6068

@weidongxu-microsoft
Copy link
Copy Markdown
Member

weidongxu-microsoft commented Oct 10, 2019 •
edited
Loading

@TinaHu1
Please double check whether this added property on stable would violate "New property added to response" in https://microsoft.sharepoint.com/:w:/r/teams/azureresourcemanagerteam/_layouts/15/guestaccess.aspx?rtime=oPAFQY8Z10g&share=EWXsAQ1yx25KkyYCeeWGUgwBSBxEdUDEbHi6FZ__U8EOQw

Also I failed to find the usage of "OrcDataset" which is affected. Could you specify?

@TinaHu1
Copy link
Copy Markdown
Contributor Author

TinaHu1 commented Oct 11, 2019

@TinaHu1
Please double check whether this added property on stable would violate "New property added to response" in https://microsoft.sharepoint.com/:w:/r/teams/azureresourcemanagerteam/_layouts/15/guestaccess.aspx?rtime=oPAFQY8Z10g&share=EWXsAQ1yx25KkyYCeeWGUgwBSBxEdUDEbHi6FZ__U8EOQw

Also I failed to find the usage of "OrcDataset" which is affected. Could you specify?

It has been used by "Dataset" at specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json by using "x-ms-discriminator-value".

@weidongxu-microsoft
Copy link
Copy Markdown
Member

weidongxu-microsoft commented Oct 11, 2019

What about 1st question?

The point is I didn't find it in https://github.com/TinaHu1/azure-rest-api-specs/blob/orccompression/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json. Not sure if I was missing anything or not. If you are sure it is in proper use then it is fine for me.

@TinaHu1
Copy link
Copy Markdown
Contributor Author

TinaHu1 commented Oct 11, 2019

What about 1st question?

The point is I didn't find it in https://github.com/TinaHu1/azure-rest-api-specs/blob/orccompression/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json. Not sure if I was missing anything or not. If you are sure it is in proper use then it is fine for me.

It should be "new property added in response", but it can not be simply treated as breaking change in ADF case, please take this PR as reference: #7040, thanks.

@weidongxu-microsoft weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 11, 2019
@weidongxu-microsoft
Copy link
Copy Markdown
Member

weidongxu-microsoft commented Oct 11, 2019

What about 1st question?
The point is I didn't find it in https://github.com/TinaHu1/azure-rest-api-specs/blob/orccompression/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json. Not sure if I was missing anything or not. If you are sure it is in proper use then it is fine for me.

It should be "new property added in response", but it can not be simply treated as breaking change in ADF case, please take this PR as reference: #7040, thanks.

OK. We will do the same ARMFeedback same as that PR.

KrisBash
KrisBash approved these changes Oct 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2019
@weidongxu-microsoft weidongxu-microsoft merged commit b988ead into Azure:master Oct 17, 2019
This was referenced Oct 17, 2019
Merged
Merged
@sjtuxzq sjtuxzq mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft

1 more reviewer

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TinaHu1 @azuresdkci @AutorestCI @weidongxu-microsoft @KrisBash @TinaHu18